chore(css): Add trackers in a pixel and fonts#3648
Open
louismaximepiton wants to merge 7 commits into
Open
Conversation
github-project-automation
Bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
There was a problem hiding this comment.
Pull request overview
This PR introduces a CSS-based “pixel tracker” intended to measure OUDS Web usage (sites + library version), and adds per-brand configuration for the tracker URL via composite tokens.
Changes:
- Adds a
#{$ouds-root-selector}::afterpseudo-element in the shared root stylesheet to trigger a tracker asset request. - Introduces
$ouds-pixel-tracker-url(per brand) in composite token files, embedding brand + library version in the query string. - Updates brand font CDN URLs to
assets.orange.com(with an added query string).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scss/_root.scss | Adds the pixel tracker request via a root pseudo-element. |
| packages/orange/scss/tokens/_composite.scss | Adds Orange tracker URL token; updates Orange font CDN URLs. |
| packages/sosh/scss/tokens/_composite.scss | Adds Sosh tracker URL token; updates Sosh font CDN URLs. |
| packages/orange-compact/scss/tokens/_composite.scss | Adds Orange Compact tracker URL token; updates Orange Compact font CDN URLs. |
Comment on lines
+12
to
+14
| #{$ouds-root-selector}::after { | ||
| content: ""; | ||
| background-image: url("#{$ouds-pixel-tracker-url}"); |
Member
Author
There was a problem hiding this comment.
Good to know indeed, keeping it open if needed for further investigations.
louismaximepiton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #3334
Description
Checklists
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews